feat: build from Node.js v24 #253
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 29.12% 29.12%
=======================================
Files 10 10
Lines 309 309
=======================================
Hits 90 90
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflows to add explicit permissions and expand Node.js version support. The changes include updating the release workflow configuration and adding Node.js 24 to the CI matrix.
- Added explicit permissions to the release workflow for better security and OIDC token support
- Updated release workflow to use
npm-release.ymlinstead ofnode-release.ymland removed NPM_TOKEN dependency - Extended CI test coverage to include Node.js 24
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added permissions block, renamed job to "NPM", switched to npm-release.yml workflow, and removed NPM_TOKEN secret |
| .github/workflows/nodejs.yml | Added Node.js 24 to the CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update binding.gyp to use C++20 standard for macOS (Linux stays on C++17) - Node.js v24 requires C++20 or later - Add comprehensive CLAUDE.md documentation for future development 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Linux uses C++17 - macOS uses C++20 (required for Node.js v24+) - Windows uses MSVC default settings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
binding.gyp:66
- The Linux build configuration still uses C++17, but the documentation in CLAUDE.md states that Node.js v24+ requires C++20. This inconsistency will cause Linux builds to fail on Node.js v24. Update the Linux cflags to use '-std=c++20' to match the macOS configuration and documentation.
"-std=c++17",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
需要先搞定 binary 编译再合并发布。 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
close #251
macOS uses C++20 (required for Node.js v24+)
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com